Skip to content

upgrade PHP in CI Docker image#2163

Merged
blued-gear merged 5 commits into
mainfrom
upgrade_dependencies-ci_docker
Jun 30, 2026
Merged

upgrade PHP in CI Docker image#2163
blued-gear merged 5 commits into
mainfrom
upgrade_dependencies-ci_docker

Conversation

@blued-gear

Copy link
Copy Markdown
Collaborator

No description provided.

@garrettw

Copy link
Copy Markdown
Contributor

I assume you must have some good reason for changing the distro? I mean, that makes this a little more than purely a PHP upgrade.

@blued-gear

Copy link
Copy Markdown
Collaborator Author

Debian does not offer PHP 8.5 yet, so I switched to a distro which does. It would also be possible to use 3th-party repos for Debian, but IMO this would rise the attack-surface as they are not reviewed by official maintainers.

@garrettw

garrettw commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Well, while you're changing the base image, why not go to an official PHP image and keep the distro the same?

php:8.5-fpm-trixie

Or if you want a lighter distro, there are Alpine versions.

@blued-gear

Copy link
Copy Markdown
Collaborator Author

I will look into them.

@blued-gear blued-gear requested a review from garrettw June 29, 2026 11:35
Comment thread ci/Dockerfile Outdated

@garrettw garrettw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works, it looks fine to me. But I'd prefer others to approve as well.

@melroy89

Copy link
Copy Markdown
Member

so https://github.com/MbinOrg/mbin/actions/runs/28337112998/job/83945142612 is still failing somehow.. despite this change? Or this first needs to be merged. I guess.

@blued-gear

Copy link
Copy Markdown
Collaborator Author

so https://github.com/MbinOrg/mbin/actions/runs/28337112998/job/83945142612 is still failing somehow.. despite this change? Or this first needs to be merged. I guess.

You are looking at an old run. The latest succeeded. https://github.com/MbinOrg/mbin/actions/runs/28393820191/job/84127318482?pr=2163

@blued-gear blued-gear merged commit 165b442 into main Jun 30, 2026
9 of 10 checks passed
@blued-gear blued-gear deleted the upgrade_dependencies-ci_docker branch June 30, 2026 20:00
@blued-gear

Copy link
Copy Markdown
Collaborator Author

I have to redo this, as

  • the Node version from Debian is too old
  • the Postgresql driver was not installed correctly (the pgsql was installed fine, but I missed that there is also a PDO_PGSQL module)

https://github.com/MbinOrg/mbin/actions/runs/28472511248/job/84388597761?pr=2162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants