upgrade PHP in CI Docker image#2163
Conversation
|
I assume you must have some good reason for changing the distro? I mean, that makes this a little more than purely a PHP upgrade. |
|
Debian does not offer PHP 8.5 yet, so I switched to a distro which does. It would also be possible to use 3th-party repos for Debian, but IMO this would rise the attack-surface as they are not reviewed by official maintainers. |
|
Well, while you're changing the base image, why not go to an official PHP image and keep the distro the same?
Or if you want a lighter distro, there are Alpine versions. |
|
I will look into them. |
garrettw
left a comment
There was a problem hiding this comment.
As long as it works, it looks fine to me. But I'd prefer others to approve as well.
|
so https://github.com/MbinOrg/mbin/actions/runs/28337112998/job/83945142612 is still failing somehow.. despite this change? Or this first needs to be merged. I guess. |
You are looking at an old run. The latest succeeded. https://github.com/MbinOrg/mbin/actions/runs/28393820191/job/84127318482?pr=2163 |
|
I have to redo this, as
https://github.com/MbinOrg/mbin/actions/runs/28472511248/job/84388597761?pr=2162 |
No description provided.