Replace MAX_IMAGE_BYTES constant in ImageManager.php with admin configurable environmental variable#987
Merged
2 commits merged intomainfrom Aug 4, 2024
Merged
Conversation
ghost
added
enhancement
ghost
self-assigned this
ghost
requested review from
ghost
changed the title
ImageManager.php to admin configurable environmental variableImageManager.php to admin configurable environmental variable
ghost
changed the title
ImageManager.php to admin configurable environmental variableImageManager.php with admin configurable environmental variable
BentiGorlich
reviewed
Aug 4, 2024
Member
BentiGorlich
left a comment
BentiGorlich
left a comment
There was a problem hiding this comment.
Do we need a fallback a lá ?? $defaultMaxBytes? Or is symfony always at least returning the max_image_bytes_default value?
melroy89
approved these changes
Aug 4, 2024
Member
melroy89
left a comment
melroy89
left a comment
There was a problem hiding this comment.
max_image_bytes is set to max_image_bytes_default (default), so I expect no issues there.
Member
|
This variable was wrongly introduced, and should have been called: Fixed: #1878 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #797
Retains "sane" default of 6000000 if admins forget to set the variable in the
.envfile.