This should fix the interruption problem that channels have#41
Merged
cpw merged 2 commits intoMcModLauncher:mainfrom Jun 15, 2023
Merged
This should fix the interruption problem that channels have#41cpw merged 2 commits intoMcModLauncher:mainfrom
cpw merged 2 commits intoMcModLauncher:mainfrom
Conversation
…by making our ZipFS File channels "uninterruptible". Also, use Files.readAllBytes() to read stuff for InputStreams (how classloaders load stuff) as that makes it's internal streams uninterruptible too. Signed-off-by: cpw <cpw+github@weeksfamily.ca>
…lose event. AbstractInterruptibleChannel seems to immediately close the underlying file channel so we should be able to detect. Signed-off-by: cpw <cpw+github@weeksfamily.ca>
marchermans
approved these changes
Jun 12, 2023
Member
marchermans
left a comment
marchermans
left a comment
There was a problem hiding this comment.
This looks good.
A bit hacky, but much better then setting the interrupt flag, since that can already be processed by the ZipFS systems earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #37