-
Notifications
You must be signed in to change notification settings - Fork 42
Remove the notExistingPath check and use proper lazy streams
#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
notExistingPath check and use a proper lazy streamsnotExistingPath check and use proper lazy streams
|
@cpw This was your code path, and I am trying to understand why it exists. Is there a reason why this uses a custom path? |
The custom path is left-over code from the initial implementation, when a path filter that wouldn't match will return the |
|
Note: just tested this on ATM9, loads fine as expected. |
The
!= notExistingPathdoesn't do anything, and thenewDirStreammethod would accumulate the results in a list, which is not efficient for dir streams that early-exit. Streams are meant to be lazy.