Fix UnionPath existence checks with nested union file systems#53
Merged
marchermans merged 1 commit intoMcModLauncher:mainfrom Nov 21, 2023
Merged
Fix UnionPath existence checks with nested union file systems#53marchermans merged 1 commit intoMcModLauncher:mainfrom
marchermans merged 1 commit intoMcModLauncher:mainfrom
Conversation
Technici4n
commented
Nov 20, 2023
Contributor
Author
|
Note: The broken behavior only appeared after 482f95d, but that commit is not really to blame - it removed checks that should have been redundant, but were in fact not because of that forgotten |
Su5eD
approved these changes
Nov 20, 2023
marchermans
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Files.existsalways returning true for layered/nested UnionFileSystems. The bug happens because of a missingelsebranch incheckAccessfor non-default and non-zip file systems.Added a test to reproduce the issue, and consolidated the fs-specific code to avoid such issues in the future.