feat: Add compose build command#72
Merged
Mcrich23 merged 3 commits intoMcrich23:mainfrom Apr 21, 2026
Merged
Conversation
Luke-Parkin
force-pushed
the
feat/compose-build
branch
from
91a2c35 to
86471a5
Compare
Luke-Parkin
force-pushed
the
feat/compose-build
branch
from
86471a5 to
b30edbd
Compare
Mcrich23
requested changes
Apr 21, 2026
Owner
Mcrich23
left a comment
Mcrich23
left a comment
There was a problem hiding this comment.
Hi @Luke-Parkin, thank you so much for patiently waiting for me to review this. Everything looks really good, but there's one thing regarding logging that needs to get fixed before I can merge it. Can you please take a look at my comment?
|
|
||
| print("\n----------------------------------------") | ||
| print("Building \(serviceName) -> \(imageTag)") | ||
| let buildCommand = try Application.BuildCommand.parse(commands) |
Owner
There was a problem hiding this comment.
Can you please also have it pass down the logging flags to respect user decisions?
Owner
There was a problem hiding this comment.
The reason why we're on a fork instead of directly tracking main is to include a macro for this. Take a look at ComposeUp for more info.
Contributor
Author
There was a problem hiding this comment.
Hope that's what you're looking for! Thanks for the review.
Mcrich23
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align closer with docker/alternatives, add a
compose buildcommand which builds images but does not launch containers.