Merged
Conversation
Owner
|
Nice fixing |
Owner
|
I was working on separate branches for ts and js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was evaluating your implementation, and made these changes while doing so.
I'd say I'm happy with the concept, and fairly happy with the API it provides. IMO, the biggest issue is that w/o async support this package has only limited usefulness.
Features:
AsyncContextManager, as a superset ofContextManager(with the same two methods / behavior)Withto support return values from the bodyAsyncWithSame thing, but asyncAsyncUseandUse(context manager to generator, as a more-limited alternative toWith)closingto (also) support async context managersFixes / tweaks:
exitactually returnedtrue, not just truthyconsole.logcalls (immediate deal-breaker, as someone evaluating a package)exit) viaarguments.length(undefinedcan be thrown)Type fixes / tweaks:
Errorvalues will ever be thrownbodytype (that was used in one place)