Improve PYTHONQTALL_CONFIG env var handling for CMD #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and other nice options like PYTHONMALLOC=debug_malloc (useful for ASan) and more rigorous warnings handling
|
Please, do not hesitate to squash-commit on merge. This fix was done from web-based editor, thus the history is a little bit messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in CMD shell on Windows, the environment variable is passed as a whole single sting literal into assignment, thus it should be "parsed" somehow. The proposed solution also allows injecting some other expressions into the literal, however, this should be safe in general use.
Fixes #211