Fix ASTString prettyprint over Hierarchical Ruleset with more than one rule and condition#334
Merged
javihern98 merged 19 commits intomainfrom Nov 12, 2025
Merged
Fix ASTString prettyprint over Hierarchical Ruleset with more than one rule and condition#334javihern98 merged 19 commits intomainfrom
javihern98 merged 19 commits intomainfrom
Conversation
… AStString HRuleset pretty formatter do not put the ';' separator between rules. Fixed some HRule pretty indent issues.
javihern98
changed the title
javihern98
changed the title
Contributor
|
We are checking now as well the DP Rulesets to ensure this issue is not replicated there |
Contributor
Author
Looking at the signature of the DPRulsetets, this error does not occur with them. |
Contributor
|
Missing specific tests for this in the AST String (and the DP Rulesets one) @mla2001 |
Contributor
Author
Done |
javihern98
approved these changes
Nov 12, 2025
Contributor
javihern98
left a comment
javihern98
left a comment
There was a problem hiding this comment.
Looks good, thanks! 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #333
Changelog