Added support for multiple locales per template file #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonrobledo
requested changes
Sep 27, 2022
| SectionsCreated = [], | ||
| { privatesAccessor } = require('@medable/mdctl-core-utils/privates') | ||
|
|
||
| let hashCode = function (str, seed = 0) { |
Collaborator
There was a problem hiding this comment.
you can add this function mdctl-node-utils package https://github.com/Medable/mdctl/blob/master/packages/mdctl-node-utils/crypto.js and use crypto that already exists.
| } | ||
| } | ||
|
|
||
| extractTemplatesGrouped() { |
Collaborator
There was a problem hiding this comment.
if extractTemplates is not longer used please remove or use the same method name.
saadb94
force-pushed
the
multiple_locales_support
branch
2 times, most recently
from
017d414 to
0e2b334
Compare
saadb94
force-pushed
the
multiple_locales_support
branch
from
0e2b334 to
c2db522
Compare
gastonrobledo
requested changes
Oct 25, 2022
packages/mdctl-node-utils/crypto.js
Outdated
| return hash.digest('hex') | ||
| } | ||
|
|
||
| function hashCode(str, seed = 0) { |
Collaborator
There was a problem hiding this comment.
When I said you could use crypto I mean you could use this
const hash = createHash('md5')
hash.update(str)
return hash.digest('hex')
1748e82 to
44b13ad
Compare
gastonrobledo
previously approved these changes
Oct 26, 2022
saadb94
force-pushed
the
multiple_locales_support
branch
from
44b13ad to
4b42bd0
Compare
gastonrobledo
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by i18n Initiative.
Multiple locales supported via array per template file. New fn is backward compatible as well for the old style of export.
If one locale, then template file is named according to that. If multiple, then its a hash of the locales array. Otherwise, if it is * then the template file is named anyLocale.
Things to consider: