Skip to content

Conversation

@javibravo
Copy link
Contributor

No description provided.

@javibravo javibravo requested review from omnific9 and vincetse June 5, 2017 15:14
@vincetse
Copy link
Contributor

vincetse commented Jun 5, 2017

Fantastic addition to the docs. 👍

Copy link

@omnific9 omnific9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there other improvements coming? What are next steps before the next engineer review?

@javibravo
Copy link
Contributor Author

There are not improvements in progress. There is a list of issues (nice-to-have features) opened:
https://github.com/MediaMath/lambda-cron/issues

There are some features that would add real value to the project. Do you think we should mention it in the introduction?

Step before next engineering review: Run a code review and ensure there are not code that compromise MM.

vincetse
vincetse previously approved these changes Jun 6, 2017
@javibravo javibravo merged commit 96fd476 into master Jun 8, 2017
@javibravo javibravo deleted the documentation branch June 8, 2017 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants