Skip to content

add spread() to kew#46

Merged
nicks merged 1 commit intomasterfrom
nick-spread
May 13, 2015
Merged

add spread() to kew#46
nicks merged 1 commit intomasterfrom
nick-spread

Conversation

@nicks
Copy link
Contributor

@nicks nicks commented May 13, 2015

Hello @kylehg,

Please review the following commits I made in branch 'nick-spread'.

9ad3424 (2015-05-13 18:55:25 -0400)
add spread() to kew

R=@kylehg

test/spread.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@kylehg
Copy link
Contributor

kylehg commented May 13, 2015

This is awesome, @nicks! I was just thinking how we should have the equivalent of RSVP.hash(), but this is even better

@kylehg
Copy link
Contributor

kylehg commented May 13, 2015

I don't understand the Travis failures, but lgtm

@nicks
Copy link
Contributor Author

nicks commented May 13, 2015

we're going to have a separate pr to discuss nathan's concerns about Q.all

nicks added a commit that referenced this pull request May 13, 2015
@nicks nicks merged commit fb98f18 into master May 13, 2015
@nicks nicks deleted the nick-spread branch May 13, 2015 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants