Open
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Fix bool vector serialization: include partial byte in buffer when there are unfilled bits - Fix type mismatch in system.go: change FP32Vector default decoder from FP16Vector to Float32Vector - Add bitmap bounds checking: validate bitmap indices before access in deserialized_psdb_layout2.go - Check bounds in countSetBitsBefore() to prevent panic on undersized bitmaps - Check bounds in skipStringVectorsInDense() before bitmap access - Check bounds in GetNumericVectorFeature() and GetBoolVectorFeature() bitmap iteration Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- LLD_TEMPLATE_FOR_WORD.txt: Word-compatible template with 686 lines - WORD_IMPORT_GUIDE.txt: Step-by-step import instructions - lld_doc_generation_prompt.md: Comprehensive LLM prompt with 12 sections - LLD_TEMPLATE.md: Markdown version for GitHub documentation - COMMIT_ANALYSIS.md: Detailed analysis of 14 commits - README.md: Quick start guide for all usage workflows - INDEX.txt: Master navigation index - GENERATION_SUMMARY.txt: Feature highlights Covers PSDB Layout V2 & V3 bitmap-based sparse feature encoding. Ready for Word document creation or LLM-based generation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- psdb_shadow_compare.go: return pooled PSDB to pool on Build() error (pool leak fix) - system/system.go: fix GetFP32Vector using FP16 decoder for FP32 defaults - perm_storage_datablock_v3.go: fix sparse bool vector partial byte truncation, add setupBoolDtypeLastIdx; make setupHeadersLayout2 idempotent (overwrite instead of append on repeat calls) - cache_storage_datablock_v2.go: add uint16 overflow guard for payloads > 64KB - perm_storage_datablock_v2.go: fix comment (byte 8 bit 3 → byte 9 bit 0) - deserialized_psdb_v3.go: add bounds checks for pos in GetStringVectorFeature and GetBoolVectorFeature - layout_comparison_test.go: guard divide-by-zero in Conclusion block; use safe type assertion for DeserializedPSDBLayout2; remove hardcoded rationale numbers - redis.go: preserve lifetime-TTL (ExpiryAt==0) PSDBs when building Redis CSDBs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- cache_storage_datablock_v2_test.go: replace hardcoded 3-byte defaults with ddb.GetDataType().Size() for all GetNumericScalarFeature calls (14 sites)
- deserialized_psdb_v2_test.go: same fix for d.GetDataType().Size() (12 sites)
- handler/feature/persist.go: fix metric tags to use colon-separated format ("key:value") matching metric.TagAsString() convention
- deserialized_psdb_v3.go: add comments explaining dual bit-ordering in GetBoolVectorFeature (bitmap=LSB-first, dense payload=MSB-first)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
📂 Modules Affected
horizon(Real-time systems / networking)online-feature-store(Feature serving infra)trufflebox-ui(Admin panel / UI)infra(Docker, CI/CD, GCP/AWS setup)docs(Documentation updates)___________Added tests
Key Requirement Doc
Downstream Impact
Additional Information