Target SDK 35 Migration For Chucker#110
Merged
aryan-meesho merged 5 commits intodevelopfrom Aug 12, 2025
Merged
Conversation
| */ | ||
| private fun setWindowInsets(view: View) { | ||
| if (Build.VERSION.SDK_INT >= 35) { | ||
| ViewCompat.setOnApplyWindowInsetsListener(view) { v, insets -> |
Collaborator
There was a problem hiding this comment.
ViewCompat.setOnApplyWindowInsetsListener(view) { v, insets ->
val systemBars = insets.getInsets(
WindowInsetsCompat.Type.systemBars() or WindowInsetsCompat.Type.displayCutout()
)
val ime = insets.getInsets(WindowInsetsCompat.Type.ime())
// Prevent flicker between nav bar and keyboard
v.updatePadding(
left = systemBars.left,
top = systemBars.top,
right = systemBars.right,
bottom = max(systemBars.bottom, ime.bottom)
)
// Pass through for children to handle too
insets
}
Collaborator
There was a problem hiding this comment.
how does this work instead
Author
There was a problem hiding this comment.
this works the same as before. Have made these changes
| * This handles system bars, display cutout, and IME insets. | ||
| */ | ||
| private fun setWindowInsets(view: View) { | ||
| if (Build.VERSION.SDK_INT >= 35) { |
Collaborator
There was a problem hiding this comment.
can put this to caller site, wont need to come to this func itself if build version is less 35
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-bin.zip |
Collaborator
There was a problem hiding this comment.
instead of these changes, should check this parent repo, and merge update for change logs
Chucker
| buildscript { | ||
| ext { | ||
| kotlinVersion = '1.6.21' | ||
| kotlinVersion = '1.7.20' |
Collaborator
There was a problem hiding this comment.
these are similar to what we have in supply ?
…declaration after AGP version upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: APT-4739
Added window insets handling for Android 15 (Target SDK 35) devices.
Before handling insets:
After handling insets: