Skip to content

Conversation

@yzchen
Copy link
Contributor

@yzchen yzchen commented Oct 20, 2020

更新 nlp/bert 模型代码

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@wjfwzzc wjfwzzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要签一下CLA。
先改为提PR到imperative-runtime分支,后续统一处理CI的问题(主要是pylint)。

还有以下问题需要回答一下:

  1. trace可用么?trace现在是默认开启的,要改为默认关掉么?
  2. 训练测试都只支持单卡?

@yzchen
Copy link
Contributor Author

yzchen commented Oct 20, 2020

需要签一下CLA。
先改为提PR到imperative-runtime分支,后续统一处理CI的问题(主要是pylint)。

还有以下问题需要回答一下:

1. trace可用么?trace现在是默认开启的,要改为默认关掉么?

2. 训练测试都只支持单卡?
  1. trace 在1.0.0应该不能用,matmul某些情况trace会出错,改完了就能用,我把改之后的patch拿来测试的。看起来还是暂时关了?
  2. 这里的修改就是复现了 README.md 文档里的内容,之前支持的只有单卡,现在就也只有单卡。

@yzchen yzchen changed the base branch from master to imperative-runtime October 20, 2020 07:10
Copy link
Collaborator

@wjfwzzc wjfwzzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wjfwzzc wjfwzzc merged commit 880e1cf into MegEngine:imperative-runtime Oct 20, 2020
wjfwzzc pushed a commit that referenced this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants