feat(ci): use new ci to check code format #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjfwzzc
reviewed
Oct 20, 2020
wjfwzzc
reviewed
Oct 20, 2020
Collaborator
|
LGTM. |
wjfwzzc
pushed a commit
that referenced
this pull request
Oct 21, 2020
* feat(models): update ci * fix(models): fix flake8 and isort in vision * fix(models): fix pylint error and refine gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在CI中新增了flake8和isort
目前对于nlp，quant和vision中的gan/keypoint并不做检查
如果需要进行检查，对于flake和isort，可以进入setup.cfg把skip部分注释掉
pylint部分需要修改.github/workflow/ci.yml下的CI