Skip to content

Conversation

@lixiangyin666
Copy link
Collaborator

update quantization codebase

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@wjfwzzc wjfwzzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others请 @zhouyizhuang-megvii 帮忙看

@wjfwzzc wjfwzzc changed the title update quantization codebase to 1.0 feat(quantization): update quantization codebase to 1.0 Oct 20, 2020
Copy link
Collaborator

@zhouyizhuang-megvii zhouyizhuang-megvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouyizhuang-megvii
Copy link
Collaborator

CI也请修一下

@lixiangyin666 lixiangyin666 force-pushed the master branch 2 times, most recently from 7632c6e to 5dc7cdd Compare October 21, 2020 07:05
Copy link
Collaborator

@wjfwzzc wjfwzzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup.cfg[isort]skip没去掉quantization
others LGTM.

@wjfwzzc wjfwzzc merged commit 11f13b4 into MegEngine:imperative-runtime Oct 21, 2020
wjfwzzc pushed a commit that referenced this pull request Oct 21, 2020
* feat(quantization): update quantization codebase to 1.0

* refactor(quantization): refactor ci by using shell script and change quantization code for format check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants