ci: drop @semantic-release/git so releases work under branch protection#2
Merged
Merged
Conversation
The git plugin pushes a `chore(release): X.Y.Z [skip ci]` commit back to `main`, which fails when the branch is protected. Tags and GitHub Releases are still created by `@semantic-release/github` via the API, which is not subject to branch-push protection. Trade-offs: - CHANGELOG.md is no longer maintained in the repo (release notes still live on each GitHub Release page). - MARKETING_VERSION in the pbxproj stays static. The build pipeline rewrites it via sed before xcodebuild, so the shipped .app has the correct version regardless. Also dropped: - @semantic-release/changelog (would write CHANGELOG.md that never gets persisted) from both npm install steps. - The release job's `cp artifacts/project.pbxproj` step, which only existed so the git plugin had the version-bumped pbxproj to commit.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The git plugin pushes a
chore(release): X.Y.Z [skip ci]commit back tomain, which fails when the branch is protected. Tags and GitHub Releases are still created by@semantic-release/githubvia the API, which is not subject to branch-push protection.Trade-offs:
Also dropped:
cp artifacts/project.pbxprojstep, which only existed so the git plugin had the version-bumped pbxproj to commit.