feat: formalize canonical internal finding model#11
Merged
meisterware-admin merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
- tighten Finding and Evidence as the canonical normalized pipeline model - add canonical taxonomy and severity constants for OpenPAKT-aligned values - update MVP rules and tests for consistent canonical findings and deterministic aggregation
nerd114
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Issue #4 by formalizing the internal normalized finding model used across the Detektor scan pipeline.
The change tightens
FindingandEvidenceas the canonical internal structures for detected security issues, adds canonical taxonomy and severity constants aligned with OpenPAKT, and updates the current MVP rules to emit stable canonical values consistently. The goal is to make findings the clear internal pipeline currency before Issue #5 report generation.Type of change
Select all that apply:
Related issue
Closes #4
What changed
Findingas the canonical normalized internal model with:idtypeseveritycomponentdescriptionevidenceEvidencewith:summarylocationsnippetDetektor.OpenPAKT.Constants.FindingTypesPromptInjectionRuleandToolPermissionValidationRuleto emit canonical OpenPAKT-aligned values consistentlyImpact
This change makes the internal finding model the clear canonical structure used between rule execution, aggregation, and future report mapping.
Expected impact:
This PR does not change report output, CLI behaviour, or add new reporting/policy/scenario features.
Compatibility
Choose one:
If Breaking change, explain migration considerations.
Checklist
Notes for reviewers
This PR is intentionally scoped only to Issue #4.
It does not implement:
Verification completed:
dotnet test Detektor.sln