Conversation
rskew
reviewed
Sep 24, 2018
| /** Writing to the angular velocity file */ | ||
| Vector3D vel = satellite.getStates().getCurrentState().getAttitude().getSpin(); | ||
| vel.normalize(); | ||
| if (vel.getNorm() != 0) { |
Collaborator
There was a problem hiding this comment.
Should this check if it's equal to 1 instead?
Author
There was a problem hiding this comment.
No the purpose of this is to check for divide by zero errors, this is correct
|
|
||
| /** Writing to the angular velocity file */ | ||
| Vector3D vel = satellite.getStates().getCurrentState().getAttitude().getSpin(); | ||
| vel.normalize(); |
Collaborator
There was a problem hiding this comment.
Here the operation is used as if it works in-place, but all the other uses of it treat it as if it returns the computed value. Maybe remove this line as it's redundant with the check on the next couple of lines.
Author
There was a problem hiding this comment.
Yep, I forgot to delete that line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.