-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add a quick-start doc article #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rollandf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
thuffmlx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
I would add at least 1-3 more 2ndary RDMA network definitions.
Most configurations have 4-8 NICS and consequently 4-8 parallel secondary RDMA networks. Would help clarify the list of networks in the annotations, and the corresponding list of resource requests. I've encountered customers that tried to dump all of the NICs in to the same secondary network as a pool.
755f209 to
01a1960
Compare
Hey @thuffmlx, please take a look at the new version. I've added more RDMA network definitions to IPoIB RDMA shared use case |
rollandf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Thanks
01a1960 to
8fd2c3a
Compare
Documentation previewhttps://mellanox.github.io/network-operator-docs/review/pr-225 |
| } | ||
| nvIpam: | ||
| image: nvidia-k8s-ipam | ||
| repository: |nvidia-ipam-repository| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a suggestions but you could use something more "standard"
like using envsubst instead of needing to generate sed cmd for each var in vars.rst.
that means
- have var.env file created from release.yaml
- generate vars.rsh from 1
- generate examples using vars from 1
example: in templates you will put something like: repository: $NVIDIA_IPAM_REPO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
let's fix this in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue created:
#238
* Add a new quick start section with (almost) ready-to-use deployment examples * Add keywords to use case definitions for ease of future automated parsing * Store examples as separate files and build them to allow automated deployments * Rename getting started with k8s to deployment guide and put it on the same level with quick start guide Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
TBD: