Skip to content

fix: update missing downstreamFork flags#2712

Merged
rollandf merged 1 commit into
Mellanox:masterfrom
rollandf:downstreamFork
Jul 5, 2026
Merged

fix: update missing downstreamFork flags#2712
rollandf merged 1 commit into
Mellanox:masterfrom
rollandf:downstreamFork

Conversation

@rollandf

@rollandf rollandf commented Jul 5, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes three components in hack/release.yamlSriovIbCni, rdmaCni, and DraDriverSriov — that were missing the downstreamFork: true flag, which controls how the release workflow creates release branches and tags for those repositories.

  • Without downstreamFork: true, the release workflow would treat these repos as NVIDIA-owned projects: for beta releases it tags on the default branch (no release branch created), and for GA it errors if a release branch does not already exist. For downstream forks, a release branch is expected to be created on every release type (beta, RC, GA), so the missing flag caused incorrect branching behavior in the release pipeline.
  • The fix is targeted and consistent with the existing pattern; all three added entries have a unique sourceRepository with no other sharing entries, so the workflow's downstreamFork consistency validation passes cleanly.

Confidence Score: 5/5

Safe to merge — the change correctly restores missing flags and aligns with existing patterns in the file.

Three simple additive config lines restore downstreamFork: true on components that were clearly meant to carry it (they follow the same pattern as neighbouring entries like SriovCni and ovsCni). The release workflow already validates consistency of this flag across shared sourceRepositories, so any future drift would be caught automatically. No logic changes and no risk of unintended side effects.

No files require special attention.

Important Files Changed

Filename Overview
hack/release.yaml Adds downstreamFork: true to SriovIbCni, rdmaCni, and DraDriverSriov; consistent with the existing pattern for downstream-fork components and passes the workflow's consistency validation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Release workflow triggered] --> B[get-managed-components\nbuild downstream_forks map]
    B --> C{For each sourceRepository\nin matrix}
    C --> D{downstreamFork == true?}
    D -->|YES\nSriovIbCni / rdmaCni / DraDriverSriov\nnow correctly marked| E[Create release branch\non every release type\nbeta / RC / GA]
    D -->|NO\nNVIDIA-owned repos| F{Release type?}
    F -->|beta| G[Tag on default branch\nno release branch created]
    F -->|rc| H[Create release branch\nfrom default branch]
    F -->|GA| I{Branch exists?}
    I -->|yes| J[Tag on release branch]
    I -->|no| K[ERROR: exit 1]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Release workflow triggered] --> B[get-managed-components\nbuild downstream_forks map]
    B --> C{For each sourceRepository\nin matrix}
    C --> D{downstreamFork == true?}
    D -->|YES\nSriovIbCni / rdmaCni / DraDriverSriov\nnow correctly marked| E[Create release branch\non every release type\nbeta / RC / GA]
    D -->|NO\nNVIDIA-owned repos| F{Release type?}
    F -->|beta| G[Tag on default branch\nno release branch created]
    F -->|rc| H[Create release branch\nfrom default branch]
    F -->|GA| I{Branch exists?}
    I -->|yes| J[Tag on release branch]
    I -->|no| K[ERROR: exit 1]
Loading

Reviews (1): Last reviewed commit: "fix: update missing downstreamFork flags" | Re-trigger Greptile

@rollandf rollandf merged commit 3d84906 into Mellanox:master Jul 5, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants