Skip to content

[Bug]: evaluation/episodic_memory script use obsoleted APIs #1210

@1saac-k

Description

@1saac-k

Describe the bug

The scripts located in evaluation/episodic_memory/locomo_*.py still call the create_episodic_memory_manager API, which was removed in version v0.2.0.

Additionally, these scripts appear to depend on other legacy APIs that are no longer functional in the current v0.3.0 release.

I am aware that the retrieval_agent introduced in v0.3.0 is recommended, but as long as the episodic_memory scripts have not yet been removed, they still require refactoring.

Steps to reproduce

In the evaluation/episodic_memory directory, run python locomo_ingest.py --data-path ../data/locomo10.json

(mm) (Supermicro-EMR) ~/ws/mm/evaluation/episodic_memory $ python locomo_ingest.py --data-path ../data/locomo10.json
Traceback (most recent call last):
  File "/home/kwangjin/ws/mm/evaluation/episodic_memory/locomo_ingest.py", line 105, in <module>
    asyncio.run(main())
  File "/usr/lib/python3.12/asyncio/runners.py", line 194, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/kwangjin/ws/mm/evaluation/episodic_memory/locomo_ingest.py", line 28, in main
    memory_manager = EpisodicMemoryManager.create_episodic_memory_manager(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: type object 'EpisodicMemoryManager' has no attribute 'create_episodic_memory_manager'. Did you mean: 'create_episodic_memory'?

Expected behavior

Use proper APIs.

Environment

  • OS: Linux (Ubuntu 24.04)
  • MemMachine: v0.3.0

Additional context

If this is already in progress, could you let me know? I’m also working on the fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions