Skip to content

Resolve ruff issues#1043

Merged
edwinyyyu merged 1 commit intoMemMachine:mainfrom
edwinyyyu:ruff_fix
Feb 4, 2026
Merged

Resolve ruff issues#1043
edwinyyyu merged 1 commit intoMemMachine:mainfrom
edwinyyyu:ruff_fix

Conversation

@edwinyyyu
Copy link
Copy Markdown
Contributor

Purpose of the change

Ruff actions were not locked to pyproject.toml. Breaking change in ruff break CI.

Description

Lock ruff version to pyproject.toml

Fixes/Closes

Fixes #1037

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

Not tested.

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu
Copy link
Copy Markdown
Contributor Author

Failing tests are due to client not being a separate package.

@sscargal
Copy link
Copy Markdown
Contributor

sscargal commented Feb 3, 2026

Thanks for the quick fix. The client unit tests run in Python 3.14 but not in 3.10. We should handle this problem in a separate bug.

Copy link
Copy Markdown
Contributor

@sscargal sscargal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff tests now pass. Thanks!

@edwinyyyu edwinyyyu merged commit 70f176e into MemMachine:main Feb 4, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Ruff 0.15.0 Reports Failures for Existing Code – Action Blocked Until FURB110/FURB171 Issues Resolved

3 participants