Skip to content

Fix Caeleb MJ Entity Issues (partially)#2009

Merged
AN-BC merged 1 commit intonextfrom
an-dev-9
Feb 23, 2026
Merged

Fix Caeleb MJ Entity Issues (partially)#2009
AN-BC merged 1 commit intonextfrom
an-dev-9

Conversation

@AN-BC
Copy link
Copy Markdown
Contributor

@AN-BC AN-BC commented Feb 23, 2026

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 23, 2026

⚠️ No Changeset found

Latest commit: d1535e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@claude
Copy link
Copy Markdown

claude bot commented Feb 23, 2026

Claude finished @AN-BC's task —— View job


Review Complete ✅

I've completed the review of PR #2009 for migration files.

Review Checklist:

  • Start a pending PR review
  • Get list of changed files in the PR
  • Identify any migration files (*.sql in migrations/ directory)
  • Review migration files for hard-coded UUIDs in INSERT statements and spCreate calls
  • Submit review as COMMENT type

Summary

No migration files were found in this PR. All 7 changed files are TypeScript source files and package-lock.json. The changes appear to be renaming entity classes to have an "MJ" prefix (e.g., TestEntityMJTestEntity, CredentialEntityMJCredentialEntity).

Since there are no SQL migration files in this PR, there were no INSERT statements or spCreate calls to review for hard-coded UUIDs.

The review has been submitted as a non-blocking comment.

@AN-BC
Copy link
Copy Markdown
Contributor Author

AN-BC commented Feb 23, 2026

@CaelebB-BC we have a critical issue. You didn't run CodeGen or build again on a FRESH MJ install after pulling from next so you broke the next branch by merging. You must always do a full npm run build before you merge a PR after you pull from next.

HERE - I MOSTLY fixed your issues but you must apply your migration (and fix the version # and date) to be for 5.3! After that you will ahve updated code generated that will fix the remaining issues.

@AN-BC AN-BC merged commit bd4a4dc into next Feb 23, 2026
3 of 4 checks passed
@AN-BC AN-BC deleted the an-dev-9 branch February 23, 2026 23:51
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration File Review

I've reviewed this PR specifically for SQL migration files as requested.

Summary

No migration files were found in this PR. All changes are to TypeScript source files and package-lock.json. The changes appear to be renaming entity classes to have an "MJ" prefix (e.g., TestEntityMJTestEntity, CredentialEntityMJCredentialEntity).

Since there are no SQL migration files to review for hard-coded UUIDs in INSERT statements or spCreate calls, no migration-specific issues were found.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Dependency Check Results

All dependencies are properly declared!

No missing dependencies detected in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant