feat: HubSpot association v4 fetch, empty-string datetime fix, OpenAI streaming fix#2177
Merged
feat: HubSpot association v4 fetch, empty-string datetime fix, OpenAI streaming fix#2177
Conversation
…, and OpenAI max_completion_tokens fix Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 43d6342 The changes in this PR will be included in the next version bump. This PR includes changesets to release 190 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @madhavrs1's task —— View job SQL Migration Review CompletedReview Tasks:
SummaryI've completed the review focusing on SQL migration files as requested. No migration files were found in this PR - all changes are in source code (TypeScript) and metadata (JSON) files. Therefore, there were no INSERT statements or spCreate procedures to check for hard-coded UUIDs. The PR includes:
Since there are no migration files to review, the PR passes the requested checks by default. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
SQL Migration Review
I've reviewed this PR specifically for SQL migration files as requested.
No migration files were found in this PR. The changes include:
.changeset/bright-wolves-hunt.md- Changeset configurationmetadata/integrations/.hubspot.json- HubSpot integration metadata- TypeScript source files for HubSpot connector and OpenAI integration
Since there are no migrations/*.sql files to review for INSERT statements or spCreate procedures with hard-coded UUIDs, there are no migration-related concerns to address.
Contributor
✅ Dependency Check ResultsAll dependencies are properly declared! No missing dependencies detected in this PR. |
Contributor
Author
|
Just a quick overview of the changes made here:
|
AN-BC
reviewed
Mar 19, 2026
| messages: formattedMessages, | ||
| temperature: params.temperature, | ||
| max_tokens: params.maxOutputTokens, | ||
| max_completion_tokens: params.maxOutputTokens, |
Contributor
There was a problem hiding this comment.
@madhavrs1 did this change in the OpenAI API? This type of thing deserves a comment if you're modifying a long standinng component in the system
Contributor
Author
There was a problem hiding this comment.
Hi Amith, youre right, I added a global pr comment instead of starting a review and adding an inline comment.
There I state:
"openAI.ts, very minor change I noticed, if alright, streaming path uses max_completed_tokens now as newer models ignore depricated 'max_tokens.'"
Contributor
There was a problem hiding this comment.
got it, sorry didn't see that
AN-BC
reviewed
Mar 19, 2026
Contributor
AN-BC
left a comment
AN-BC
left a comment
There was a problem hiding this comment.
except the OpenAI thing, LGTM
AN-BC
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchChangesoverride to route association objects through HubSpot's v4 per-object associations endpoint, with batched parent iteration, full pagination, and composite ExternalID generation''for unset properties — normalizes tonullinFlattenHubSpotRecordto prevent SQL conversion errors on datetime/numeric columnsGetCachedObject/GetCachedFieldschangedprivate→protectedso HubSpot connector can access object metadata for association dispatchmax_completion_tokens: Fixes streaming path to use the modern parameter name (non-streaming path already used it) — newer models (o1, o3) silently ignored the oldmax_tokensparameterTest plan
npm run buildpasses for integration-connectors, integration-engine, ai-openai🤖 Generated with Claude Code