Default category setting for extend_exp_duration()#76
Merged
wangben718 merged 9 commits intomainfrom Feb 19, 2025
Merged
Conversation
fukuhiro2023
changed the title
extend_exp_duration()
LittleBeannie
approved these changes
Feb 19, 2025
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thanks, @fukuhiro2023 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets default values for the arguments of
extend_exp_duration()so that it uses metadata, and addsextract_duration_category_ranges()to obtain real numbers from labels for exposure duration categories. Also, updatesplotly_exp_duration()to align the display order of histogram type with that ofplot_type_label.