Conversation
…eMaintenance The Rust workspace is growing fast — 5 crates already, more landing as the port progresses. Without grouping, every minor/patch bump from crates.io produces its own PR; with two managers (`cargo` and `github-actions`) on a stack of stacked PRs that quickly drowns review. - Group `cargo` minor/patch updates into a single weekly PR. - Group `github-actions` minor/patch updates the same way. - Enable `lockFileMaintenance` for `Cargo.lock` (Monday morning) so indirect dep drift doesn't accumulate between explicit Cargo.toml changes. Major bumps still get their own PR (default behaviour kept) so they stay easy to triage individually. Change-Id: I7506fae52e2c6bfb2c12af80391b1eb07a9b93f0
|
This pull request is part of a Mergify stack:
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 🔎 ReviewsWaiting for:
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
Updates Renovate configuration to reduce dependency update PR noise as the Rust workspace grows, by grouping related updates and enabling periodic lockfile maintenance.
Changes:
- Enable Renovate
lockFileMaintenanceon a Monday-morning schedule. - Group
cargominor/patch updates into a single PR. - Group
github-actionsminor/patch updates into a single PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "lockFileMaintenance": { | ||
| "enabled": true, | ||
| "schedule": [ | ||
| "before 5am on monday" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
lockFileMaintenance is enabled globally, so Renovate will run lockfile maintenance PRs for all supported lockfiles in the repo (e.g., uv.lock in addition to Cargo.lock). The PR description says this is intended only for Cargo.lock; consider disabling lockfile maintenance by default and re-enabling it only for the cargo manager (or filtering to Cargo.lock if supported) via packageRules targeting matchUpdateTypes: ["lockFileMaintenance"].
| { | ||
| "matchManagers": [ | ||
| "cargo" | ||
| ], | ||
| "matchUpdateTypes": [ | ||
| "minor", | ||
| "patch" | ||
| ], | ||
| "groupName": "Cargo minor/patch updates" | ||
| }, |
There was a problem hiding this comment.
This rule groups Cargo minor/patch updates, but it doesn’t actually make them weekly as stated in the PR description. If the intent is a single weekly PR, add an explicit schedule (either in this packageRule or via a global/preset weekly schedule) so Renovate won’t open/update the grouped PR continuously throughout the week.
| { | ||
| "matchManagers": [ | ||
| "github-actions" | ||
| ], | ||
| "matchUpdateTypes": [ | ||
| "minor", | ||
| "patch" | ||
| ], | ||
| "groupName": "GitHub Actions minor/patch updates" | ||
| } |
There was a problem hiding this comment.
This rule groups GitHub Actions minor/patch updates, but there’s no schedule configured to make it a weekly PR as described. Add an explicit schedule for this rule (or a global/preset weekly schedule) to align behavior with the PR description.
The Rust workspace is growing fast — 5 crates already, more landing as
the port progresses. Without grouping, every minor/patch bump from
crates.io produces its own PR; with two managers (
cargoandgithub-actions) on a stack of stacked PRs that quickly drowns review.cargominor/patch updates into a single weekly PR.github-actionsminor/patch updates the same way.lockFileMaintenanceforCargo.lock(Monday morning) soindirect dep drift doesn't accumulate between explicit Cargo.toml
changes.
Major bumps still get their own PR (default behaviour kept) so they
stay easy to triage individually.