chore: replace pathlib.PurePosixPath.full_match with a translated regex
#856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for fb89d7b. 🟢 All jobs passed!But CI Insights is watching 👀 |
sileht
previously approved these changes
Oct 31, 2025
…egex This allows to use both `/` and `\\` in the patterns to match any filename that could also have either of them, independently of the OS on which the code is running. Change-Id: I18f26b83bdd47cc0c4405ec3f1c48d3a9d50fb54
Greesb
force-pushed
the
devs/greesb/use_glob_translate/I18f26b83bdd47cc0c4405ec3f1c48d3a9d50fb54
branch
from
cdfb764 to
fb89d7b
Compare
Member
Author
|
I removed a pushed file that shouldn't have been pushed |
jd
approved these changes
Oct 31, 2025
JulianMaurin
approved these changes
Oct 31, 2025
Contributor
|
✅ The pull request has been merged |
mergify
bot
deleted the
devs/greesb/use_glob_translate/I18f26b83bdd47cc0c4405ec3f1c48d3a9d50fb54
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use both
/and\\in the patterns to match anyfilename that could also have either of them, independently of the OS on
which the code is running.