Pull request for master#283
Merged
Merged
Conversation
sileht
added
strict-workflow
jd
previously requested changes
Oct 23, 2018
|
|
||
| if pull.g_pull.state == "closed": | ||
| redis.srem(_get_cache_key(pull), pull.g_pull.number) | ||
| LOG.debug("pull request have been closed or merged", |
| elif pull.is_behind(): | ||
| # NOTE(sileht): Someone can have merged something manually in | ||
| # base branch in the meantime, so we have to update it again. | ||
| LOG.debug("pull request need to be updated again", |
| if not pull.is_behind(): | ||
| if pull.g_pull.state == "closed": | ||
| redis.srem(_get_cache_key(pull), pull.g_pull.number) | ||
| LOG.debug("pull request have been closed or merged", |
Member
Author
|
Pull-request updated, HEAD is now 2eccd87 |
Member
Author
|
Pull-request updated, HEAD is now 2eccd87 |
Member
Author
|
Pull-request updated, HEAD is now f3d937d |
Pull requests can be closed or merged manually. We can skip those and move to the next one.
jd
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge: strict, handle manually closed/merged pr
merge: fixup logging