Skip to content

Cleanup domain name for fs HostOnly cookies #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023
Merged

Cleanup domain name for fs HostOnly cookies #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/.vuepress/components/cookie-consent/cookie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,12 @@ export default class Coookie {
* Finsweet merginmaps.com is not able to write cookies to .merginmaps.com, because they have own merginmaps.com cookie.
* Prirority is .merginmaps.com, so users options are not sharing between subdomains.
*
* Best solution is to use window.location.hostname.
* Best solution is to use window.location.hostname or no domain HostOnly=true cookies.
* */
domainName = ''

constructor(cookieConsentName) {
this.cookieConsentName = cookieConsentName || this.cookieConsentName
if (typeof window === 'object') {
this.domainName = window.location.hostname
}
}

_getByName(name) {
Expand Down