Skip to content

Added empty or loading MMList delegate for dropdown filters#4453

Merged
Withalion merged 4 commits intodev/filteringfrom
filter-add-loading-spinner
Apr 16, 2026
Merged

Added empty or loading MMList delegate for dropdown filters#4453
Withalion merged 4 commits intodev/filteringfrom
filter-add-loading-spinner

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

@gabriel-bolbotina gabriel-bolbotina commented Apr 15, 2026

  • added new empty or loading MM List delegate component
  • used in for the dropdown filter inputs (unique, value relation, value map)
  • updated the value map model to load data similarly to the other models
  • added Behavior on height change for MMDrawer
  • modified MMListMultiSelect to expand the drawer in case the search field is tapped when not in full screen mode
  • formatted QML code

New UI:

ScreenRecording_04-15-2026.15-16-52_1.MP4
no-items.mov

Modified MMDrawer to animate on height changes
Updated the value map model to update the config during a load
Modified MMListMultiSelect to expand when the search is tapped
Added spinner when loading more items
modified the logic in the dropdown filter input types
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Coverage Report for CI Build 24506320783

Coverage decreased (-0.2%) to 58.304%

Details

  • Coverage decreased (-0.2%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 98 coverage regressions across 8 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

98 previously-covered lines in 8 files lost coverage.

File Lines Losing Coverage Coverage
mm/app/filter/valuemapfiltermodel.cpp 39 0.0%
mm/app/valuerelationfeaturesmodel.cpp 30 70.49%
mm/app/filter/uniquevaluesfiltermodel.cpp 19 0.0%
mm/app/position/providers/simulatedpositionprovider.cpp 6 85.71%
mm/app/filter/uniquevaluesfiltermodel.h 1 0.0%
mm/app/filter/valuemapfiltermodel.h 1 50.0%
mm/app/layerfeaturesmodel.h 1 0.0%
mm/app/valuerelationfeaturesmodel.h 1 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 15095
Covered Lines: 8801
Line Coverage: 58.3%
Coverage Strength: 100.67 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 66961 dmg Expires: 14/07/2026 #6696
linux Build 📬 Mergin Maps 67071 x86_64 Expires: 14/07/2026 #6707
win64 Build 📬 Mergin Maps 58911 win64 Expires: 14/07/2026 #5891
Android Build 📬 Mergin Maps 800811 APK [armeabi-v7a] Expires: 14/07/2026 #8008
📬 Mergin Maps 800811 APK [armeabi-v7a] Google Play Store #8008
Android Build 📬 Mergin Maps 800851 APK [arm64-v8a] Expires: 14/07/2026 #8008
📬 Mergin Maps 800851 APK [arm64-v8a] Google Play Store #8008
iOS Build Build failed or not found. #8947

@gabriel-bolbotina gabriel-bolbotina added enhancement map tools Something is wrong with recording, geometry editing, splitting, stakeout, .. labels Apr 16, 2026
@gabriel-bolbotina gabriel-bolbotina added this to the 2026.2.0 milestone Apr 16, 2026
@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 67011 dmg Expires: 15/07/2026 #6701
linux Build 📬 Mergin Maps 67121 x86_64 Expires: 15/07/2026 #6712
win64 Build 📬 Mergin Maps 58961 win64 Expires: 15/07/2026 #5896
Android Build 📬 Mergin Maps 801351 APK [arm64-v8a] Expires: 15/07/2026 #8013
📬 Mergin Maps 801351 APK [arm64-v8a] Google Play Store #8013
Android Build 📬 Mergin Maps 801311 APK [armeabi-v7a] Expires: 15/07/2026 #8013
📬 Mergin Maps 801311 APK [armeabi-v7a] Google Play Store #8013
iOS Build 📬 Build number: 26.04.895211 #8952

@Withalion Withalion merged commit cb6b8d6 into dev/filtering Apr 16, 2026
11 of 12 checks passed
@Withalion Withalion deleted the filter-add-loading-spinner branch April 16, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement map tools Something is wrong with recording, geometry editing, splitting, stakeout, ..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants