Integrated custom check box in filtering controller#4455
Merged
Withalion merged 3 commits intodev/filteringfrom Apr 16, 2026
Merged
Integrated custom check box in filtering controller#4455Withalion merged 3 commits intodev/filteringfrom
Withalion merged 3 commits intodev/filteringfrom
Conversation
gabriel-bolbotina
added
enhancement
map tools
Withalion
reviewed
Apr 16, 2026
Comment on lines
+90
to
+91
| property var representationForTrue: root.customValueForTrue != null ? root.customValueForTrue : true | ||
| property var representationForFalse: root.customValueForFalse != null ? root.customValueForFalse : false |
Contributor
Contributor
Author
There was a problem hiding this comment.
The only use case is if we want to keep integer custom values or not. If we have 0 and 1 as custom options
Contributor
There was a problem hiding this comment.
okay let's keep it then how it was
Coverage Report for CI Build 24508389648Coverage decreased (-0.1%) to 58.315%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions43 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Withalion
approved these changes
Apr 16, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Just reverse the representationForXXX conditions to how they were before and you can merge
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added function to get the checkbox configuration for custom values
Modified MM filters panel to support custom label and values for segment control.
UI:
segment-control-integration.mov