Fixed silent crash and filter input behaviour for numbers#4457
Merged
Withalion merged 5 commits intodev/filteringfrom Apr 20, 2026
Merged
Fixed silent crash and filter input behaviour for numbers#4457Withalion merged 5 commits intodev/filteringfrom
Withalion merged 5 commits intodev/filteringfrom
Conversation
Added logging for these scenarios Fixed checked status for filter inputs added guards for other potential silent crashes added support for negative numbers and 0 as inputs for number range filters
Coverage Report for CI Build 24656131403Warning No base build found for commit Coverage: 58.063%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Apr 18, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
In general I would prefer triggering the logging when the filter tries to get applied and fails instead of when the filter is loaded from QgsProject
Contributor
Author
I think we need to choose between the expected behaviour: I think that they should not appear in the drawer at all, as they don't have a target layer nor field. |
📦 Build Artifacts Ready
|
gabriel-bolbotina
added
map tools
Withalion
reviewed
Apr 20, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Just last bits to improve resilience and debugging
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Withalion
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.