Skip to content

Fixed date and date time filtering#4461

Merged
Withalion merged 2 commits intodev/filteringfrom
fix-date-time
Apr 20, 2026
Merged

Fixed date and date time filtering#4461
Withalion merged 2 commits intodev/filteringfrom
fix-date-time

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

Fixed the date time filtering by:

  • checking whether the filter input is DateTime or just normal date. Before we would convert date only inputs to dateTime and in some cases the filtering would fail, e.g., a lower-bound filter with today's date and 00:00:00 would exclude today's records if the field is date only. Now, the date only will not have any time component and dateTime behaves as before.
  • convert local time to UTC

Added check whether the input is date or dateTime
@gabriel-bolbotina gabriel-bolbotina changed the title Added UTC conversion to check dateTime inputs Fixed date and date time filtering bug Apr 20, 2026
@gabriel-bolbotina gabriel-bolbotina self-assigned this Apr 20, 2026
@gabriel-bolbotina gabriel-bolbotina changed the title Fixed date and date time filtering bug Fixed date and date time filtering Apr 20, 2026
@gabriel-bolbotina gabriel-bolbotina added map tools Something is wrong with recording, geometry editing, splitting, stakeout, .. enhancement labels Apr 20, 2026
@gabriel-bolbotina gabriel-bolbotina added this to the 2026.2.0 milestone Apr 20, 2026
@github-actions
Copy link
Copy Markdown

Coverage Report for CI Build 24667146177

Coverage decreased (-0.03%) to 57.912%

Details

  • Coverage decreased (-0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 90 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

90 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
mm/app/filtercontroller.cpp 89 4.46%
mm/app/layerfeaturesmodel.cpp 1 80.47%

Coverage Stats

Coverage Status
Relevant Lines: 15211
Covered Lines: 8809
Line Coverage: 57.91%
Coverage Strength: 100.4 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build Build failed or not found. #6724
linux Build 📬 Mergin Maps 67351 x86_64 Expires: 19/07/2026 #6735
win64 Build 📬 Mergin Maps 59191 win64 Expires: 19/07/2026 #5919
Android Build 📬 Mergin Maps 803651 APK [arm64-v8a] Expires: 19/07/2026 #8036
📬 Mergin Maps 803651 APK [arm64-v8a] Google Play Store #8036
Android Build 📬 Mergin Maps 803611 APK [armeabi-v7a] Expires: 19/07/2026 #8036
📬 Mergin Maps 803611 APK [armeabi-v7a] Google Play Store #8036
iOS Build 📬 Build number: 26.04.897511 #8975

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 67242 dmg Expires: 19/07/2026 #6724
linux Build 📬 Mergin Maps 67351 x86_64 Expires: 19/07/2026 #6735
win64 Build 📬 Mergin Maps 59191 win64 Expires: 19/07/2026 #5919
Android Build 📬 Mergin Maps 803651 APK [arm64-v8a] Expires: 19/07/2026 #8036
📬 Mergin Maps 803651 APK [arm64-v8a] Google Play Store #8036
Android Build 📬 Mergin Maps 803611 APK [armeabi-v7a] Expires: 19/07/2026 #8036
📬 Mergin Maps 803611 APK [armeabi-v7a] Google Play Store #8036
iOS Build 📬 Build number: 26.04.897511 #8975

@Withalion Withalion merged commit 3576381 into dev/filtering Apr 20, 2026
5 of 9 checks passed
@Withalion Withalion deleted the fix-date-time branch April 20, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement map tools Something is wrong with recording, geometry editing, splitting, stakeout, ..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants