Skip to content

Fixed filters activated status for map floating button#4462

Merged
Withalion merged 1 commit intodev/filteringfrom
fix-reset-layer-activated-filters
Apr 20, 2026
Merged

Fixed filters activated status for map floating button#4462
Withalion merged 1 commit intodev/filteringfrom
fix-reset-layer-activated-filters

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

Bug scenario:

  • have filters from only one layer applied to the whole project
  • reset/ clear the filters for only that layer via the filter banner Reset button

Actual result: the filters are cleared but the map floating button is still showing active filters, even though no filters are active

Expected result: when clearing a layer's filters and these are the only filters project wise, the map floating button should disappear and the status of the active filters be updated

Fix:

  • created a function to check updates on the field filters member variable based on existing code
  • Called this function at the end of clearLayersFilters to properly update the status and thus the floating button visibility

Called function at the end of clearlayersfilters to properly update the floating button
@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build Build failed or not found. #6725
linux Build Build failed or not found. #6736
win64 Build 📬 Mergin Maps 59201 win64 Expires: 19/07/2026 #5920
Android Build 📬 Mergin Maps 803751 APK [arm64-v8a] Expires: 19/07/2026 #8037
📬 Mergin Maps 803751 APK [arm64-v8a] Google Play Store #8037
Android Build 📬 Mergin Maps 803711 APK [armeabi-v7a] Expires: 19/07/2026 #8037
📬 Mergin Maps 803711 APK [armeabi-v7a] Google Play Store #8037
iOS Build 📬 Build number: 26.04.897611 #8976

@Withalion Withalion merged commit 608338f into dev/filtering Apr 20, 2026
7 of 9 checks passed
@Withalion Withalion deleted the fix-reset-layer-activated-filters branch April 20, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants