V2 list projects endpoint #558
Conversation
Pull Request Test Coverage Report for Build 21023258346Details
💛 - Coveralls |
| from sqlalchemy.exc import IntegrityError | ||
| import pytest | ||
| from datetime import datetime, timedelta, timezone | ||
| import json |
There was a problem hiding this comment.
json lib is useful for loading response data
resp_data = json.loads(resp.data)
you can examine the response in debug mode - without saving the response to the variable I see a loading values for the object in my IDE, which is inconvenient.
| return True | ||
|
|
||
| if permissions == "read": | ||
| if permissions == "guest": |
There was a problem hiding this comment.
why this? This could not affect rest of endpoints?
There was a problem hiding this comment.
IMO it should be there there in oder to be able to share a specific project with a user when all global roles are disabled
in that case, the user is a guest, and without this update, this method will return false, and the access would be refused
yes, need to be careful about this, I can double-check the implementations of this method
| format: date-time | ||
| description: File modification timestamp | ||
| example: 2024-11-19T13:50:00Z | ||
| ProjectDetail: |
There was a problem hiding this comment.
Why do we need new ProjectDetail?
There was a problem hiding this comment.
it's Project with files
- in the list project endpoint I want to return Project without files so I separated those two
Resolves https://github.com/MerginMaps/server-private/issues/3154
Example:
