Add configurable confirm dialog logo and update Project Settings#635
Open
xkello wants to merge 2 commits into
Open
Add configurable confirm dialog logo and update Project Settings#635xkello wants to merge 2 commits into
xkello wants to merge 2 commits into
Conversation
Coverage Report for CI Build 26746454661Coverage remained the same at 93.215%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
Jun 1, 2026
|
|
||
| const logoSrc = computed(() => { | ||
| const variant = | ||
| props.logoVariant === 'auto' |
Contributor
Author
There was a problem hiding this comment.
Thats the fall back logic. If not variant is specified use the default logic and use logo based on severity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration to change confirm dialog logo bg to fill the figma (https://www.figma.com/design/Zl8irhQtrHrxBVcJyLPedL/Dashboard-2.0?node-id=3355-10739&t=mtqPIiHeupfZI8d1-0) requirements. Behavior only applies when it is defined for the logo. When its left empty (default setting) the logo follows old logic - bg changes according to button variant.
Update some names according to figma specs above