Skip to content

Add PIA UI quality OpenCode skill#19

Open
MerverliPy wants to merge 21 commits into
mainfrom
ui-quality-skill
Open

Add PIA UI quality OpenCode skill#19
MerverliPy wants to merge 21 commits into
mainfrom
ui-quality-skill

Conversation

@MerverliPy

Copy link
Copy Markdown
Owner

Summary

  • Add .opencode/skills/ui-quality/SKILL.md as a local UI-quality layer inspired by the taste-skill integration plan.
  • Scope the skill to apps/web/, .ui-redesign/, mobile/PWA surfaces, shared CSS, page builders, UI states, visual hierarchy, and design-contract validation.
  • Preserve PIA governance by making AGENTS.md, repository adapter, decision ledger, approved contracts, and existing route/API/data/dependency boundaries higher authority than the skill.
  • Update .opencode/REGISTRY.md from 12 to 13 skills and register ui-quality so registry-count CI remains aligned.

Validation

  • Verified the new skill file on branch ui-quality-skill.
  • Verified .opencode/REGISTRY.md shows 25 agents, 28 commands, 13 skills and includes ui-quality in the skills table.

Notes

Direct commit to main was blocked by repository rules, so this change is provided through a PR as required.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbbbf01f18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


- the task would require a new design decision;
- the task would modify protected areas without approval;
- the approved design contract is missing, stale, or contradictory;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid blocking pre-contract design phases

When this skill is used for /mobile-ui-design-contract or concept work (the skill applies to .ui-redesign/ and design-contract validation), this stop condition fires before an approved design contract exists, even though .opencode/commands/mobile-ui-design-contract.md is the workflow that creates and proposes that contract. That makes the pre-contract redesign phase report instead of editing the contract artifacts; limit this stop to implementation work that depends on an existing approved contract.

Useful? React with 👍 / 👎.

MerverliPy commented Jun 20, 2026

Copy link
Copy Markdown
Owner Author

Implementation update after expanding the requested taste-skill additions:

  • Added 7 additional local skills:
    • visual-concept-quality
    • output-completeness
    • image-to-implementation-bridge
    • readme-landing-quality
    • brand-system-quality
    • mobile-state-design
    • design-contract-lint
  • Added 2 commands:
    • /ui-quality-audit
    • /ui-quality-fix
  • Added 3 templates:
    • ui-quality-audit-template.md
    • visual-concept-critique-template.md
    • output-completeness-check-template.md
  • Updated 5 agents to reference the new local quality layer:
    • mobile-ui-orchestrator
    • frontend-implementer
    • visual-concept-prototyper
    • accessibility-performance-validator
    • workflow-improvement-reviewer
  • Updated .opencode/REGISTRY.md to 25 agents, 30 commands, 20 skills.
  • Updated scripts/ci/check-registry-counts.sh so the registry remains the source of truth for file-count validation.

Review feedback noted that ui-quality could block pre-contract concept/design-contract work if the missing-contract stop condition applied too broadly; this still needs a small follow-up patch to narrow that stop condition to implementation work only.

Note: the PR body still reflects the initial smaller version of this PR because the later implementation expanded scope through follow-up commits and this comment records the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant