feat: api for mobile app#8
Merged
Merged
Conversation
Collaborator
Author
|
@coderabbitai review |
- C1: Add MIME type whitelist to file uploads (prevent RCE)
- C2: Whitelist entity_type in AttachmentController (prevent IDOR)
- H1-H3: Add authorize('viewAny') to 13 index methods
- H4: Validate system setting values by type
- H5: Add Admin/Supervisor auth to SystemController::schedule()
- H6: Hide MQTT password_encrypted via $hidden on model
- H7: Enforce password confirmation + strength rules on reset
- M1: Rate limit password reset endpoint (throttle:5,1)
- M3: Restrict assignable roles to known whitelist
- M5: Add line-scoped access check for Packaging scan (Operator)
- M6: Fix postgres volume path (restore /data suffix)
- M7: Fix postgres image version (18 → 17-alpine)
- Fix AuditLogTest/ReportTest missing role seeder
- Fix UserApiTest password_confirmation for new rules
Contributor
Security Review — SummaryReviewed 90 files (7319 additions). Found 2 CRITICAL, 7 HIGH, 7 MEDIUM issues. All issues fixed in commit Critical (fixed)
High (fixed)
Medium (fixed)
Pre-existing (not in scope)
Tests: 529/529 pass (excl. pre-existing Packaging module issue) |
- Remove hardcoded guard_name='sanctum' from User model - Change all roles/permissions to guard 'web' (seeder + migration) - Add 'pin' to User $hidden (was leaking hashed PIN in API responses) - Update scramble to ^0.12.36 with lock file - Fix test guard_name references (sanctum→web)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api for mobile app
Type of change
Related issue
Closes #
Testing
php artisan testpassesChecklist
.envsecrets committed$fillableupdated if new model columns addedcomposer auditclean