Harden A2A/ACP agent definition validation#1
Open
IvGolovach wants to merge 1 commit into
Open
Conversation
Validation * Validation tier: Tier 2 - narrow Mesh Agents validation and CLI diagnostics refresh for superseding Mesh-LLM/mesh-llm#765 in the agents repo; no mesh-llm core protocol, gossip, or runtime route change. * git fetch --no-tags origin main:refs/remotes/origin/main: PASS, origin/main at 0e2171b. * git diff --check: PASS, no output. * git diff --cached --check: PASS, no output. * cargo fmt --all -- --check: PASS. * cargo test -p mesh-agents-a2a --lib: PASS, 11 passed. * cargo test -p mesh-agents-acp-bridge --lib: PASS, 12 passed, 2 ignored live ACP smokes. * cargo test -p mesh-agents --bins: PASS, 12 passed. * cargo check -p mesh-agents: PASS. * rustup run stable cargo clippy -p mesh-agents-a2a -p mesh-agents-acp-bridge -p mesh-agents --all-targets -- -D warnings: PASS. * cargo run -p mesh-agents --bin agents -- agents validate pr-review --dir examples --json: PASS, status ok with 1 enabled ACP agent. * Ledger: not applicable - not required for selected validation tier/change family. * Version: not applicable - no release/version sync required for this non-release validation/CLI change. * Not run: live OpenCode/Goose/Pi ACP harness smoke - not required for selected validation tier; live ACP tests remain ignored unless a configured harness/provider is available. * Not run: two-node mesh discovery smoke - not required for selected validation tier; this PR only hardens local agent definition validation and CLI reporting. Rollback * git revert HEAD
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This lands the A2A/ACP agent-definition work in
Mesh-LLM/agents, where the mesh-native agent control plane now lives.Users get stricter local validation for agent directories and clearer CLI diagnostics before an agent definition is accepted. The PR keeps A2A/ACP-specific ownership in the agents repo and avoids adding parallel agent crates or protocol surface to
mesh-llmcore.Why
This supersedes Mesh-LLM/mesh-llm#765. That PR proved the initial direction, but review correctly pointed out that the implementation belongs in
Mesh-LLM/agents.The stale design issue Mesh-LLM/mesh-llm#692 should also be moved, updated, or closed after this agents-side PR is created so future A2A/ACP work is routed to the repo that owns it.
Diff Scope
mesh-agents-a2a.agents validate --jsonreporting for runtime/policy counts and local diagnostics.Non-Goals
mesh-llmcore runtime change.Branch Integrity
Mesh-LLM/agentsmain0e2171b26f18dfe6bd4faa390e7c9badcd28e734IvGolovach/agentscodex/a2a-acp-agent-substrate9062ac74f922a445b7bfad03d12a71fa89c118c30 behind / 1 aheadDiff Hygiene
Changed files:
README.mdcrates/mesh-agents-a2a/src/registry.rscrates/mesh-agents-acp-bridge/src/lib.rscrates/mesh-agents-cli/src/agents.rscrates/mesh-agents-cli/src/main.rscrates/mesh-agents-cli/src/mesh.rsskills/mesh-agent-authoring/SKILL.mdProof:
git diff --check origin/main...HEAD: PASS, no output.git diff --check: PASS, no output.git diff --cached --check: PASS, no output.Validation
Validation tier: Tier 2 - narrow Mesh Agents validation and CLI diagnostics refresh for superseding Mesh-LLM/mesh-llm#765 in the agents repo; no
mesh-llmcore protocol, gossip, runtime route, or release metadata change.git fetch --no-tags origin main:refs/remotes/origin/main: PASS,origin/mainat0e2171b.git diff --check origin/main...HEAD: PASS, no output.git diff --check: PASS, no output.git diff --cached --check: PASS, no output.cargo fmt --all -- --check: PASS.cargo test -p mesh-agents-a2a --lib: PASS, 11 passed.cargo test -p mesh-agents-acp-bridge --lib: PASS, 12 passed, 2 ignored live ACP smokes.cargo test -p mesh-agents --bins: PASS, 12 passed.cargo check -p mesh-agents: PASS.rustup run stable cargo clippy -p mesh-agents-a2a -p mesh-agents-acp-bridge -p mesh-agents --all-targets -- -D warnings: PASS.cargo run -p mesh-agents --bin agents -- agents validate pr-review --dir examples --json: PASS, status ok with 1 enabled ACP agent.Ledger: not applicable - not required for selected validation tier/change family.
Version: not applicable - no release/version sync required for this non-release validation/CLI change.
Not Run
Follow-Up After This PR Opens
Rollback Plan
Rollback: revert this PR.
DB downgrade: not applicable.
Data repair: not applicable.
Operational caveats: none known.