Merged
Conversation
added 5 commits
July 5, 2023 15:16
…sh_creation # Conflicts: # source/MRMesh/MRMesh.vcxproj # source/MRMesh/MRMesh.vcxproj.filters
Fedr
reviewed
Jul 6, 2023
source/MRMesh/MRMesh.h
Outdated
|
|
||
| // append points to mesh and connect them | ||
| // returns first EdgeId of new edges | ||
| MRMESH_API EdgeId addSeparateContours( const Contours3f& contours, const AffineXf3f* shift = nullptr ); |
Fedr
reviewed
Jul 6, 2023
| MR_TIMER; | ||
|
|
||
| auto bodyContours = body.contours(); | ||
| auto trajectoryContours = trajectory.contours(); |
Contributor
There was a problem hiding this comment.
if we use only contours here, probably take them on input instead of Polyline3?
Fedr
reviewed
Jul 6, 2023
| /// if not set body accumulative normal is used | ||
| std::optional<Vector3f> bodyNormal; | ||
| /// optional transform trajectory space to body space | ||
| const AffineXf3f* t2bXf{ nullptr }; |
Contributor
There was a problem hiding this comment.
do we really need it? The user can transform either the input contours, or transform resulting mesh
Fedr
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.