Fix triangle intersection with no edge-tri pairs#1410
Merged
Conversation
Fedr
reviewed
Jul 11, 2023
| return true; // DE segment penetrates triangle ABC since points B and C are at distinct sides of ADE | ||
|
|
||
| if ( abdf == 0 && acde == 0 ) | ||
| return true; // ... |
Contributor
There was a problem hiding this comment.
some comment would be highly appreciated. Let us draw a picture first, and when write it.
Fedr
reviewed
Jul 11, 2023
| MR::Vector3f { +30.f, -52.f, 0.f }, | ||
| MR::Vector3f { 0.f, 0.f, 0.f }, | ||
| }; | ||
| constexpr MR::Vector3f add( const MR::Vector3f& a, const MR::Vector3f& b ) |
Contributor
There was a problem hiding this comment.
let us remove this func, and use operator +
Fedr
approved these changes
Jul 11, 2023
Fedr
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.