Conversation
Fedr
reviewed
Jul 11, 2023
| res.set( r ); | ||
| } | ||
| return res; | ||
| return getIncidentFaces( topology, getIncidentVerts_( topology, edges ) ); |
Contributor
There was a problem hiding this comment.
New implementation is right, but let us preserve the old one as function getNeighborFaces
Fedr
reviewed
Jul 11, 2023
source/MRMesh/MRRegionBoundary.h
Outdated
| [[nodiscard]] MRMESH_API VertBitSet getIncidentVerts( const MeshTopology & topology, const UndirectedEdgeBitSet & edges ); | ||
| // composes the set of all faces incident to given edges | ||
| [[nodiscard]] MRMESH_API FaceBitSet getIncidentFaces( const MeshTopology & topology, const UndirectedEdgeBitSet & edges ); | ||
| // composes the set of all faces neighboring given edges |
Contributor
There was a problem hiding this comment.
better say from all left and right faces
Fedr
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.