Conversation
Fedr
reviewed
Jul 21, 2023
source/MRMesh/MRReadTIF.h
Outdated
| }; | ||
|
|
||
| // | ||
| VoidOrErrStr readRawTif( const std::filesystem::path& path, RawTifOutput& output ); |
Fedr
reviewed
Jul 21, 2023
source/MRMesh/MRReadTIF.h
Outdated
| // main output data, should be allocated | ||
| float* data{ nullptr }; | ||
| // parameters to compare if reading series of files | ||
| const TifParameters* params{ nullptr }; |
Fedr
reviewed
Jul 21, 2023
| struct RawTifOutput | ||
| { | ||
| // main output data, should be allocated | ||
| float* data{ nullptr }; |
Contributor
There was a problem hiding this comment.
if the user allocates it, then it is better to pass the size of allocation not to write in not-allocated memory
Fedr
reviewed
Jul 21, 2023
source/MRMesh/MRReadTIF.cpp
Outdated
| public: | ||
| TifHolder( const std::filesystem::path& path, const char* mode ) | ||
| { | ||
| tifPtr_ = TIFFOpen( utf8string( path ).c_str(), mode ); |
Contributor
There was a problem hiding this comment.
Why do we write tif with one F, while the library writes it with 2 Fs?
Contributor
There was a problem hiding this comment.
Does it work with not-ASCII symbols in pathname?
Fedr
reviewed
Jul 21, 2023
source/MRMesh/MRReadTIF.h
Outdated
| Uint, | ||
| Int, | ||
| Float, | ||
| Unknown |
Contributor
There was a problem hiding this comment.
may be put Unknown first in the list (no give it value 0)?
Fedr
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.