Conversation
Grantim
approved these changes
Jul 24, 2023
source/MRMesh/MRGcodeProcessor.cpp
Outdated
| res.idle = moveMode_ == MoveMode::Idle; | ||
|
|
||
| Vector3f rotationAnglesStep_ = ( *inputRotation_ - rotationAngles_ ) / ( pointInRotation - 1.f ); | ||
| Vector3f rotationAnglesStep_ = ( newRotationAngles - rotationAngles_ ) / ( pointInRotation - 1.f ); |
Contributor
There was a problem hiding this comment.
what if pointInRotation == 1
Contributor
Author
There was a problem hiding this comment.
impossible. pointInRotation is constant equal 21
source/MRMesh/MRGcodeProcessor.cpp
Outdated
| const int pointCount = int( res.action.path.size() ); | ||
| res.toolDirection.resize( pointCount ); | ||
| const Vector3f rotationAnglesStep_ = ( *inputRotation_ - rotationAngles_ ) / ( pointCount - 1.f ); | ||
| const Vector3f rotationAnglesStep_ = ( newAngles - rotationAngles_ ) / ( pointCount - 1.f ); |
Contributor
Author
There was a problem hiding this comment.
impossible. in this logic branch minimum value is 11 (as result previous method)
source/MRMesh/MRGcodeProcessor.cpp
Outdated
| res.toolDirection.resize( pointInRotation ); | ||
| const Vector3f lineStep = ( newPoint - translationPos_ ) / ( pointInRotation - 1.f ); | ||
| const Vector3f rotationAnglesStep_ = ( *inputRotation_ - rotationAngles_ ) / ( pointInRotation - 1.f ); | ||
| const Vector3f rotationAnglesStep_ = ( newAngles - rotationAngles_ ) / ( pointInRotation - 1.f ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix rotation in relative input mode
fix setting idle mode