I2375 added active voxels in volume render by ABSitf · Pull Request #1630 · MeshInspector/MeshLib

ABSitf · 2023-09-21T05:37:20Z

No description provided.

Grantim · 2023-09-21T07:45:58Z

source/MRMesh/MRObjectVoxels.h

+    const VoxelBitSet& getVolumeRenderActiveVoxels() const { return volumeRenderActiveVoxels_; }
+    MRMESH_API void setVolumeRenderActiveVoxels( const VoxelBitSet& activeVoxels );


please add comments

Grantim · 2023-09-21T07:48:46Z

source/MRMesh/MRObjectVoxels.cpp

+    volumeRenderActiveVoxels_.clear();
+    auto newDims = activeBox_.size();
+    volumeRenderActiveVoxels_.resize( newDims.x * newDims.y * newDims.z, true );
+    dirty_ |= DIRTY_SELECTION;


why make it here? better in prepareDataForVolumeRendering

we change active box, it can change box size, so if we try to get active voxels, we will get wrong data

Grantim · 2023-09-21T07:49:10Z

source/MRMesh/MRObjectVoxels.cpp

+    volumeRenderActiveVoxels_.clear();
+    volumeRenderActiveVoxels_.resize( vdbVolume_.dims.x * vdbVolume_.dims.y * vdbVolume_.dims.z, true );


if we construct object after creating and try get active voxels, we don't expect empty bitset

Grantim · 2023-09-21T07:49:22Z

source/MRMesh/MRObjectVoxels.cpp

+    volumeRenderActiveVoxels_.clear();
+    volumeRenderActiveVoxels_.resize( vdbVolume_.dims.x * vdbVolume_.dims.y * vdbVolume_.dims.z, true );


Grantim · 2023-09-21T07:50:11Z

source/MRViewer/MRRenderVolumeObject.h

 namespace MR
 {
-class RenderVolumeObject : public IRenderObject
+class MRVIEWER_CLASS RenderVolumeObject : public IRenderObject


do we need export this class?

why we don't need this (unlike others object classes)?

Grantim · 2023-09-21T07:50:48Z

source/MRViewer/MRRenderVolumeObject.h

+protected:
+    Vector2i activeVoxelsTextureSize_;
+
+    MRVIEWER_API RenderBufferRef<unsigned> loadActiveVoxelsTextureBuffer_();
+
+    GlTexture2 activeVoxelsTex_;
+    int maxTexSize_{ 0 };


why protected?

Grantim · 2023-09-21T07:56:16Z

source/MRViewer/MRVolumeShader.cpp

+    uint dimsXY = uint( dims.y * dims.x );
+    uint dimsX = uint( dims.x );


Suggested change

uint dimsXY = uint( dims.y * dims.x );

uint dimsX = uint( dims.x );

uint volumeSize = uint( dims.z *dims.y * dims.x );

uint dimsXY = uint( dims.y*dims.x );

Grantim · 2023-09-21T07:57:35Z

source/MRViewer/MRVolumeShader.cpp


+        {
+            ivec2 texSize = textureSize( activeVoxels, 0 );
+            uint voxelId = uint( textCoord.z * dims.z ) * dimsXY + uint( textCoord.y * dims.y ) * dimsX + uint( textCoord.x * dims.x );


Suggested change

uint voxelId = uint( textCoord.z * dims.z ) * dimsXY + uint( textCoord.y * dims.y ) * dimsX + uint( textCoord.x * dims.x );

uint voxelId = uint( textCoord.z * volumeSize ) + uint( textCoord.y * dimsXY ) + uint( textCoord.x * dims.x );

textCoord is not voxel center (textCoord = voxelCenter + smallShift)
so uint( textCoord.z * volumeSize ) have additional error

Grantim · 2023-09-21T07:58:42Z

source/MRViewer/MRVolumeShader.cpp

there can be uint overflow for big volumes voxel index it makes sanse to calculate voxel index directly

ABSitf added 2 commits September 18, 2023 13:54

added active voxels in volume render

16ac48c

update shared and some fix

3d86ecd

Grantim requested changes Sep 21, 2023

View reviewed changes

ABSitf added 2 commits September 21, 2023 18:32

fix

1a42d2e

fix

8bc40d6

Grantim approved these changes Sep 21, 2023

View reviewed changes

ABSitf merged commit 0b4c4e6 into master Sep 22, 2023

ABSitf deleted the i2375_active_voxels branch September 22, 2023 03:13

		const VoxelBitSet& getVolumeRenderActiveVoxels() const { return volumeRenderActiveVoxels_; }
		MRMESH_API void setVolumeRenderActiveVoxels( const VoxelBitSet& activeVoxels );

		volumeRenderActiveVoxels_.clear();
		volumeRenderActiveVoxels_.resize( vdbVolume_.dims.x * vdbVolume_.dims.y * vdbVolume_.dims.z, true );

		uint dimsXY = uint( dims.y * dims.x );
		uint dimsX = uint( dims.x );

	uint voxelId = uint( textCoord.z * dims.z ) * dimsXY + uint( textCoord.y * dims.y ) * dimsX + uint( textCoord.x * dims.x );
	uint voxelId = uint( textCoord.z * volumeSize ) + uint( textCoord.y * dimsXY ) + uint( textCoord.x * dims.x );

Conversation

ABSitf commented Sep 21, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ABSitf Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ABSitf Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ABSitf Sep 21, 2023 •

edited

Loading

ABSitf Sep 21, 2023 •

edited

Loading