added set label (for ObjectLabel) in information block#275
Merged
Conversation
added ChangeLabelAction for history
Grantim
requested changes
Jul 15, 2022
source/MRViewer/ImGuiMenu.h
Outdated
Comment on lines
+86
to
+93
| struct LabelNameMemory | ||
| { | ||
| std::string lastLabel; | ||
| std::string labelBuffer; | ||
| Vector3f textPos; | ||
| std::shared_ptr<ObjectLabel> obj{ nullptr }; | ||
| bool changed{ false }; | ||
| } oldLabelName_; |
Contributor
There was a problem hiding this comment.
why save all, i think we need only label text, and why oldLabelName_ if it holds all info
Contributor
Author
There was a problem hiding this comment.
textPos & changed removed
lastLabel need for history
obj need to check change object
Grantim
reviewed
Jul 15, 2022
source/MRViewer/ImGuiMenu.cpp
Outdated
Comment on lines
+1172
to
+1174
| const auto positionedText = pObjLabel->getLabel(); | ||
| oldLabelName_.lastLabel = positionedText.text; | ||
| oldLabelName_.labelBuffer = oldLabelName_.lastLabel; |
Contributor
There was a problem hiding this comment.
why not const auto& positionedText = pObjLabel->getLabel();
Contributor
There was a problem hiding this comment.
please rename field oldLabelName_ it is not name and does not affect lables name
Grantim
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ChangeLabelAction for history