Merged
Conversation
Fedr
reviewed
Jul 15, 2022
| [[nodiscard]] MRMESH_API Mesh offsetMesh( const MeshPart& mp, float offset, const OffsetParameters& params = {} ); | ||
|
|
||
| // Offsets mesh by converting it to voxels and back two times | ||
| // only closed meshes allowed (only Offset mode) |
Contributor
There was a problem hiding this comment.
worth adding that typically offsetA and offsetB have distinct signs
Fedr
reviewed
Jul 15, 2022
source/MRMesh/MRVDBConversions.cpp
Outdated
| ProgressCallback cb ) | ||
| { | ||
| if ( cb ) | ||
| cb( 0.0f ); |
Contributor
There was a problem hiding this comment.
shall we check the result of cb?
Fedr
reviewed
Jul 15, 2022
source/MRMesh/MRVDBConversions.cpp
Outdated
Comment on lines
+66
to
+68
| const std::vector<openvdb::Vec3s>& pointsRes, | ||
| const std::vector<openvdb::Vec3I>& trisRes, | ||
| const std::vector<openvdb::Vec4I>& quadRes, |
Fedr
reviewed
Jul 15, 2022
source/MRMesh/MRVDBConversions.cpp
Outdated
| convertToVDMMesh( mp, xf, Vector3f::diagonal( voxelSize ), points, tris ); | ||
|
|
||
| if ( cb ) | ||
| cb( 0.1f ); |
Fedr
reviewed
Jul 15, 2022
source/MRMesh/MRMeshTopology.cpp
Outdated
| for ( EdgeId e : leftRing( *this, f ) ) | ||
| { | ||
| if ( !right( e ) ) | ||
| if ( isBdEdge( e, region ) ) |
Contributor
There was a problem hiding this comment.
isBdEdge is true of any boundary of the region, even if right face exists
Fedr
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.