Parametrize label's ancillary visual elements#311
Merged
Conversation
Grantim
reviewed
Jul 27, 2022
Comment on lines
+136
to
+141
| if ( root["SourcePointSize"].isDouble() ) | ||
| sourcePointSize_ = root["SourcePointSize"].asFloat(); | ||
| if ( root["LeaderLineWidth"].isDouble() ) | ||
| leaderLineWidth_ = root["LeaderLineWidth"].asFloat(); | ||
| if ( root["BackgroundPadding"].isDouble() ) | ||
| backgroundPadding_ = root["BackgroundPadding"].asFloat(); |
Contributor
There was a problem hiding this comment.
isn't there isFloat() func?
Contributor
Author
There was a problem hiding this comment.
No, there's no isFloat method.
Comment on lines
234
to
237
| std::vector<Vector2i> llineEdgesIndices { | ||
| // underscore line | ||
| { 1, 2 }, | ||
| }; |
Contributor
There was a problem hiding this comment.
mb make array as class field? and jsut control size of it here (it is always 3, but pass to GPU only number of needed)?
Contributor
Author
There was a problem hiding this comment.
Rewrote to use std::array.
Grantim
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.